feat: mcli integration #536
Conversation
gssbzn
requested review from
abner-dou,
andreaangiolillo,
coderGo93 and
themantissa
as code owners
| PublicKey string | ||
| PrivateKey string | ||
| BaseURL string | ||
| RealmBaseURL string |
There was a problem hiding this comment.
realm has a different base url, if I override the one for atlas I need to change the one for realm as well and they should not share it
There was a problem hiding this comment.
oh makes sense, thank you gustavo
| @@ -28,6 +28,8 @@ type MongoDBClient struct { | |||
| Config *Config | |||
| } | |||
|
|
|||
| var ua = "terraform-provider-mongodbatlas/" + version.ProviderVersion | |||
There was a problem hiding this comment.
extracting the duplicated UA
| @@ -63,12 +65,12 @@ func (c *Config) NewClient(ctx context.Context) (interface{}, diag.Diagnostics) | |||
| func (c *MongoDBClient) GetRealmClient(ctx context.Context) (*realm.Client, error) { | |||
| // Realm | |||
| if c.Config.PublicKey == "" && c.Config.PrivateKey == "" { | |||
| return nil, fmt.Errorf("please set `public_key` and `private_key` in order to use the realm client") | |||
| return nil, errors.New("please set `public_key` and `private_key` in order to use the realm client") | |||
There was a problem hiding this comment.
no need to format as there's no interpolation
| if len(c.Config.BaseURL) > 0 { | ||
| optsRealm = append(optsRealm, realm.SetBaseURL(c.Config.BaseURL)) | ||
| optsRealm := []realm.ClientOpt{realm.SetUserAgent(ua)} | ||
| if c.Config.BaseURL != "" && c.Config.RealmBaseURL != "" { |
There was a problem hiding this comment.
for realm you should override both
| "MONGODB_ATLAS_PUBLIC_KEY", | ||
| "MCLI_PUBLIC_API_KEY", |
There was a problem hiding this comment.
pick first non empty
| Description: "MongoDB Atlas Programmatic Private Key", | ||
| Sensitive: true, |
There was a problem hiding this comment.
[q] any reason we were not setting this? can't find any docs that says not to do it when is a configuration
There was a problem hiding this comment.
Good question, I'm not aware of any blocker either but @abner-dou @coderGo93 or @thetonymaster - any issue?
There was a problem hiding this comment.
Good eye, yes for private key should be a sensitive, I wasn't aware of that part probably it was there that from the beginning
| PrivateKey: d.Get("private_key").(string), | ||
| } | ||
|
|
||
| if baseURL, ok := d.GetOk("base_url"); ok { |
There was a problem hiding this comment.
no need to if here we already if to not use it if empty
| @@ -302,14 +315,3 @@ func HashCodeString(s string) int { | |||
| // v == MinInt | |||
| return 0 | |||
| } | |||
|
|
|||
| // HashCodeStrings hashes a list of strings to a unique hashcode. | |||
| func HashCodeStrings(hashStrings []string) string { | |||
| @@ -8,11 +8,13 @@ description: |- | |||
|
|
|||
| # MongoDB Atlas Provider | |||
|
|
|||
| The MongoDB Atlas provider is used to interact with the resources supported by [MongoDB Atlas](https://www.mongodb.com/cloud/atlas). The provider needs to be configured with the proper credentials before it can be used. | |||
| You can use the MongoDB Atlas provider to interact with the resources supported by [MongoDB Atlas](https://www.mongodb.com/cloud/atlas). | |||
There was a problem hiding this comment.
avoiding passive voice
|
|
||
| ### Environment variables | ||
| ### Environment Variables |
There was a problem hiding this comment.
env first, static later, lazy readers will stop after first example and may skip the warning is not secure
| Description: "MongoDB Atlas Programmatic Private Key", | ||
| Sensitive: true, |
There was a problem hiding this comment.
Good question, I'm not aware of any blocker either but @abner-dou @coderGo93 or @thetonymaster - any issue?
Description
Add support for
MCLI_*env variables for convenience when using both toolsType of change:
Required Checklist:
Further comments
Also includes a couple of small bug fixes when overriding the base url